Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-demo-store): use locale from accept-language header on SSR #284

Merged
merged 17 commits into from
Jul 3, 2023
Merged

fix(vue-demo-store): use locale from accept-language header on SSR #284

merged 17 commits into from
Jul 3, 2023

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Jun 22, 2023 •
edited
Loading

Description

closes: #273

TODO

  • add docs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if applicable)

Additional context

@vercel
Copy link

vercel bot commented Jun 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 7:31am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 7:31am

@mkucmus mkucmus requested a review from kstala June 26, 2023 10:18
@mkucmus mkucmus marked this pull request as ready for review June 26, 2023 10:31
@mkucmus mkucmus marked this pull request as draft June 26, 2023 15:35
@mdanilowicz mdanilowicz self-requested a review June 27, 2023 08:47
@mkucmus mkucmus marked this pull request as ready for review July 3, 2023 07:05
@patzick patzick merged commit bb48e13 into main Jul 3, 2023
@patzick patzick deleted the fix/hydration-mismatch branch July 3, 2023 10:00
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Merged
mkucmus added a commit that referenced this pull request Jul 6, 2023
@mkucmus
fix(vue-demo-store): use locale from accept-language header on SSR (#284
5ca760d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstala kstala kstala approved these changes

@patzick patzick patzick approved these changes

@mdanilowicz mdanilowicz Awaiting requested review from mdanilowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Hydration text content mismatch with fallback locale
3 participants
@mkucmus @patzick @kstala