Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo): improve cms-text-element #283

Merged
merged 7 commits into from
Jun 29, 2023
Merged

fix(demo): improve cms-text-element #283

merged 7 commits into from
Jun 29, 2023

Conversation

BrocksiNet
Copy link
Collaborator

Description

closes #275

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots (if applicable)

Before:
grafik

After:
grafik

Additional context

  • Added possibilities to support colors from admin and align
  • SSR: Still shows style="" and class="" after hard reload (did not find the root of that)
  • CSR: HTML is mostly clean without empty style and class
  • Config for UnoCSS is moved to a own config file because suggest by docu
  • Added some base styles as preflights as example (and we miss them in demo store)

@vercel
Copy link

vercel bot commented Jun 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 6:01pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 6:01pm

@BrocksiNet BrocksiNet changed the title Fix/cms text element fix(demo): improve cms-text-element Jun 22, 2023
@BrocksiNet
Copy link
Collaborator Author

I did my best to add your suggestions. 💪
Thx for your feedback guys. 💟

@BrocksiNet BrocksiNet requested a review from patzick June 28, 2023 14:33
@BrocksiNet BrocksiNet requested a review from mdanilowicz June 29, 2023 09:28
@vercel vercel bot requested a deployment to Preview – shopware-frontends-docs June 29, 2023 18:00 Abandoned
@vercel vercel bot requested a deployment to Preview – shopware-frontends-docs June 29, 2023 18:00 Abandoned
@patzick patzick merged commit e6a52ec into main Jun 29, 2023
@patzick patzick deleted the fix/cms-text-element branch June 29, 2023 18:24
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Merged
mkucmus pushed a commit that referenced this pull request Jun 30, 2023
@BrocksiNet @mkucmus
fix(demo): improve cms-text-element (#283)
7bff62f 
* fix(demo): improve cms-text-element

* chore: add changesets
mdanilowicz pushed a commit that referenced this pull request Jul 3, 2023
@BrocksiNet @mdanilowicz
fix(demo): improve cms-text-element (#283)
0b32082 
* fix(demo): improve cms-text-element

* chore: add changesets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

@mdanilowicz mdanilowicz Awaiting requested review from mdanilowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CmsElementText component does not work with CMS text styles
3 participants
@BrocksiNet @mdanilowicz @patzick