Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cms-base): enable overriding the internal components #1501

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Dec 2, 2024

Description

closes: #354

tl;dr: this change allows to overwrite also the internal components with a name starting with Sw from cms-base package.

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Dec 4, 2024 8:31am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Dec 4, 2024 8:31am

Copy link

pkg-pr-new bot commented Dec 2, 2024

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1501

@shopware-pwa/composables-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1501

@shopware-pwa/cms-base

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1501

@shopware-pwa/helpers-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1501

@shopware-pwa/nuxt3-module

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1501

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1501

commit: 15d85c9

@mkucmus
Copy link
Collaborator Author

mkucmus commented Dec 2, 2024

@kstala please have a look if the change does not break the way how cms elements and blocks are rendered 🙌🏼

@kstala
Copy link
Collaborator

kstala commented Dec 2, 2024

I checked all cms elements and apart from the well-known issue with CmsBlockImageGalleryBig, everything looks correct

@mkucmus mkucmus changed the title feat(cms-base): remove internal imports feat(cms-base): enable overriding the internal components Dec 3, 2024
@BrocksiNet
Copy link
Collaborator

Will we close that without merging?

@mkucmus
Copy link
Collaborator Author

mkucmus commented Dec 4, 2024

Will we close that without merging?

it is still being reviewed, then the PR will close #354 and unblock a customer's project.

@patzick patzick merged commit 9c84519 into main Dec 4, 2024
11 of 12 checks passed
@patzick patzick deleted the feat/override-cms-base-layer-components branch December 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Impossible to override SwXXX components (?)
4 participants