-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public class members with the parameter names in each SGObject class #5042
Comments
Hi @gf712 . I am new to Shogun. I'd like to start contributing to shogun with this issue. Can I be assigned this issue ? |
hi @justdvnsh, go for it! |
Hello! Is this issue still open? If so I would like to work on this issue. |
^following my previous comment If so, could you tell me what places/models need to have a static variable defined as in the example? Thanks! |
@gf712 I am just a beginner in the coding world but holds a good knowledge of C++ which is required here and am super interested to work on this issue. can this issue be assigned to me? That would really be great. |
@gf712 Please please assign me on this. That would really be helpful. Thanks! |
Hi! I am in an intro to swe class that is requiring me to work on my first open-source project. I was wondering if this issue is still open and if so could I get help with my first contribution? |
Currently we register parameter names using
SG_ADD(&class_member, "name", "parameter description")
. The problem is that changing the registered name (in this case "name") results in issues everytime we refactor the parameter names. To address this issue the class should register astatic constexpr std::string_view kParam = "name"
that should be used to register the class name.If we ever need to use
get
/put
we should use theseconstexpr string_views
, to avoid any typos.Example:
Parameter name is define here:
shogun/src/shogun/machine/RandomForest.h
Lines 171 to 172 in e29377d
And is used in parameter registration here:
shogun/src/shogun/machine/RandomForest.cpp
Line 207 in e29377d
The text was updated successfully, but these errors were encountered: