Add cursor on nodes from Panel #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, yes, this is great! Thanks! I was able to get your hover/highlight thing to be applied only on entities so I'll add that later on. With this new feature, I also think we can replace the double-click requirement with a single click since the entity is already highlighted and the curser changes and everything so I think it would be more intuitive and I'll add that to the pull request too. I do have a couple of questions, though, so I'll add them to the review. |
shmuelzon
reviewed
Aug 30, 2024
shmuelzon
force-pushed
the
users/guimatheus92/add-cursor-tree
branch
from
d2b4bd9 to
4cf7dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding cursor on each node from Panel (tree), to improve UX when hovering each entity.
How Has This Been Tested?
Open the panel and hover on each entity.
Checklist
Screenshots (if applicable)
Additional Context
@shmuelzon can you please check and review if code if closer to what we wanted to achieve please?
I think a better usability of this feature would be to apply only to entities, but I wasn't able to ignore the group itselft. Can you help please? Check image below: