Hi Kronos team,
While reviewing train_predictor and the dataset, I noticed a potential data-leakage issue in getitem:
So, I opened a PR with the fix and a small comment tying the change back to the paper rationale: #83
What I changed (minimal fix):
- Add some code comments to better locating the paper.
- Compute Z-score using only the lookback segment.
- Start training from the lookback boundary (predict future steps only), to better simulate deployment.
If you’d like, I can follow up with a fully causal sliding/online normalization variant as well.