Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a "lowest" php-version parameter #794

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

davereid
Copy link
Contributor

@davereid davereid commented Nov 30, 2023


name: 🎉 New Feature
about: Add option for a lowest supported php-version parameter
labels: enhancement


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion: #793

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR [briefly explain what it does]

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

@shivammathur
Copy link
Owner

@davereid

Please update this regex here for lowest and change the target to the develop branch.
https://github.com/shivammathur/setup-php/blob/main/src/utils.ts#L62

@davereid davereid changed the base branch from main to develop December 7, 2023 15:43
@davereid davereid marked this pull request as ready for review December 7, 2023 15:46
@shivammathur
Copy link
Owner

shivammathur commented Dec 7, 2023

@davereid

Please run build and release, and add the changes.

npm run build
npm run release

@davereid
Copy link
Contributor Author

davereid commented Dec 7, 2023

Added the files after the npm run build/release. I did run npm test but there are current failures on the main branch on my local and my branch did not change or add any failures.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dddb642) 100.00% compared to head (93745da) 100.00%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #794   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          591       591           
  Branches        99        99           
=========================================
  Hits           591       591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivammathur shivammathur merged commit c085ca3 into shivammathur:develop Dec 7, 2023
62 checks passed
@shivammathur
Copy link
Owner

@davereid

Thanks for contributing 🎉

It should be in the next release.

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/7132635676/workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants