-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a "lowest" php-version parameter #794
Conversation
Please update this regex here for |
Please run build and release, and add the changes. npm run build
npm run release |
Added the files after the npm run build/release. I did run npm test but there are current failures on the main branch on my local and my branch did not change or add any failures. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #794 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 591 591
Branches 99 99
=========================================
Hits 591 591 ☔ View full report in Codecov by Sentry. |
Thanks for contributing 🎉 It should be in the next release. Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/7132635676/workflow |
name: 🎉 New Feature
about: Add option for a
lowest
supportedphp-version
parameterlabels: enhancement
A Pull Request should be associated with a Discussion.
Related discussion: #793
Description
This PR [briefly explain what it does]
npm run format
before the commit.npm run lint
before the commit.npm run release
before the commit.npm test
returns with no unit test errors and all code covered.