Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread-safe setup support #651

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

flavioheleno
Copy link
Contributor

@flavioheleno flavioheleno commented Oct 5, 2022

This PR adds the thread-safe build type to PHP setups.

The structure behind debug builds was slightly changed to better reflect the multiple build type concept (release, debug and thread-safe as defined in unix.sh).

Closes #649.

@shivammathur shivammathur merged commit 37dcd1c into shivammathur:develop Oct 17, 2022
@shivammathur
Copy link
Owner

@flavioheleno thanks for working on this.

I added zts debug builds to php-builder today. So I have reverted the debug variable change and introduced a ts variable as both can be set to true.

Would you be working on adding the builds for older versions as well?

@flavioheleno
Copy link
Contributor Author

@shivammathur I'm all in for adding support to the older versions as well, where are they built?

@flavioheleno flavioheleno deleted the improv/zts branch October 17, 2022 11:59
@shivammathur
Copy link
Owner

Currently, the project uses builds from ppa:ondrej/php, but it does not have zts builds, so they would have to be added to the php-builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants