Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-state and set-output workflow commands have been deprecated #654

Closed
3 of 5 tasks
localheinz opened this issue Oct 12, 2022 · 6 comments
Closed
3 of 5 tasks

set-state and set-output workflow commands have been deprecated #654

localheinz opened this issue Oct 12, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@localheinz
Copy link
Contributor

Describe the bug

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems

  • ubuntu-latest

PHP versions

n/a

To Reproduce

See https://github.com/sebastianbergmann/phpunit/blob/9.5.25/.github/workflows/ci.yml:

jobs:
  coding-guidelines:
    name: Coding Guidelines

    runs-on: ubuntu-latest

    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: Install PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.1
          extensions: none, iconv, json, phar, tokenizer
          coverage: none
          tools: none

      - name: Run PHP-CS-Fixer
        run: ./tools/php-cs-fixer fix --dry-run --show-progress=dots --using-cache=no --verbose

Expected behavior

No deprecations

Screenshots/Logs

See https://github.com/sebastianbergmann/phpunit/actions/runs/3233102102/jobs/5294525446#step:3:14:

CleanShot 2022-10-12 at 10 31 25@2x

Additional context

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Are you willing to submit a PR?

Sure!

@localheinz localheinz added the bug Something isn't working label Oct 12, 2022
@shivammathur
Copy link
Owner

Fixed in 0575a32

I will create a new release this weekend.

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Oct 12, 2022
@localheinz
Copy link
Contributor Author

Thank you, @shivammathur!

@jrfnl
Copy link
Contributor

jrfnl commented Oct 12, 2022

Came here to report the same, only to see it already fixed. Thanks @shivammathur !

@ramondelafuente
Copy link

Wil this be a v3 release or an update of v2?

@shivammathur
Copy link
Owner

This will be an update of v2.

Rekhyt added a commit to shopgate/cart-integration-shopware that referenced this issue Oct 24, 2022
@shivammathur
Copy link
Owner

Released 2.22.0 with the fix.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants