Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP formulae with debug symbols enabled #976

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

alcaeus
Copy link
Contributor

@alcaeus alcaeus commented Aug 1, 2022


name: 🎉 New Feature
about: Adds formulae to build PHP with debug symbols
labels: enhancement


A Pull Request should be associated with a discussion.

Related discussion: #972

Description

This PR adds formulae to build PHP with debug symbols. Each file is a copy or the respective non-debug version with the following changes:

  • Name changed to match filename
  • Added --enable-debug switch to configure call
  • Adapted ${version.major_minor} or php_version() to include a -debug suffix - this is necessary to keep separate configurations and extensions

@shivammathur I believe the fetch function in .github/scripts/edit.sh may trip over these new version strings, but I'm not sure. I'm hoping the build will tell me what to change there, but I'd appreciate any pointer you could give me.

@shivammathur shivammathur added the build-complete Formula has been brewed label Aug 1, 2022
@shivammathur
Copy link
Owner

🍻 @BrewTestBot has triggered a merge.

@shivammathur shivammathur merged commit 0786adc into shivammathur:master Aug 1, 2022
@shivammathur
Copy link
Owner

@alcaeus Thanks 🎉
It should work now.

@alcaeus alcaeus deleted the debug-builds branch August 2, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants