Repository navigation
Remove every GitHub Actions workflow from the fork - #4
Merged
Merged
Conversation
Delete ci.yml, no-mistakes-required.yml, and windows-herdr-spike.yml so the fork runs no GitHub Actions on pull requests or main pushes. Keep the local gates working without them: bin/fm-lint.sh skips workflow lint with a note when the checkout has no .github/workflows directory (an empty directory still fails), and .no-mistakes.yaml declares no_ci: true so the pipeline's CI step does not wait for checks that can never register. Remove the tests whose only subject was a deleted workflow (fm-ci-workflow, fm-no-mistakes-required, the Herdr CI step-timeout case, and the current-workflows parse case), and correct the docs and the layout skill that linked to or described the deleted CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes every GitHub Actions workflow from the fork, so no pull request or
mainpush runs Actions and no required check can hold a merge:.github/workflows/ci.yml(lint, portable/serial/Herdr test lanes, macOS Bash, repo invariants).github/workflows/no-mistakes-required.yml(thePR must be raised via no-mistakescompliance check).github/workflows/windows-herdr-spike.yml(manual-dispatch spike)To keep the local gates working without those files:
bin/fm-lint.shskips workflow lint and prints a note when the checkout has no.github/workflowsdirectory. If the directory exists but holds no workflow files, lint still fails, so an accidentally emptied directory is still caught..no-mistakes.yamldeclaresno_ci: true. no-mistakes reads that setting only frommain, so it takes effect once this PR merges. After that, a pipeline run treats a PR with zero checks as ready instead of waiting forever for checks that can't appear. It never waives a check that does register.Deletes the tests whose only subject was a deleted workflow:
tests/fm-ci-workflow.test.sh,tests/fm-no-mistakes-required.test.sh, the Herdr CI step-timeout case intests/fm-test-run.test.sh, and the current-workflows parse case intests/fm-lint-workflows.test.sh. Also drops their entries frombin/fm-test-run.sh.Corrects the docs that linked to or described the deleted CI:
CONTRIBUTING.md(the compliance-check paragraph and the required-checks section are replaced by a short "GitHub Actions on this fork" section),docs/configuration.mdgate defaults,docs/fm-test-portable-shards.md,docs/verification/public-followup.md, and the operational-home-layout skill.Consequences to know before merging
bin/fm-lint.shandbin/fm-test-run.shlocally.data/,state/,config/,projects/, and.no-mistakes/paths, and thatCLAUDE.mdand.claude/skillsstay pointers. After this PR, only.gitignoreguards those paths. If that check should stay, the smallest move is a follow-up that puts it inbin/fm-lint.sh.kunchenguid/firstmate. Later syncs from upstream will bring the workflows back as conflicts.Tests
bin/fm-lint.sh(changed-file mode) passes and prints the new skip note.bin/fm-lint.sh <changed scripts>passes with full analysis.tests/fm-lint.test.shpasses, including the newtest_default_path_skips_workflow_lint_only_without_a_workflows_dir. That test covers both cases: with no directory, lint exits 0 with the note; with an empty directory, it fails withno GitHub workflow files found.tests/fm-lint-workflows.test.shpasses (15 cases).bin/fm-doc-audience-check.sh:ok surfaces=119 local_links=694.LC_ALL=C bin/fm-test-run.sh --check-coverage:FM_TEST_COVERAGE ok total=241.tests/fm-test-run.test.sh: all 38 remaining cases pass excepttest_jobs_admits_a_concurrent_safe_family. That case fails the same way on unmodifiedmainon this machine:fm-session-lock-ancestry.test.shreports that the pty-host was not reparented to init. Under theen_US.UTF-8locale,--check-coveragealso fails on unmodifiedmainwithcomm: input is not in sorted order. Both failures come from the environment, not from this change.Delivered without the no-mistakes pipeline, as asked.