Add implementation of numProcs for AIX with cgo#2022
Merged
shirou merged 3 commits intoshirou:masterfrom Mar 13, 2026
Merged
Conversation
…ost-add-missing-num-procs-aix
shirou
reviewed
Mar 9, 2026
Owner
shirou
left a comment
shirou
left a comment
There was a problem hiding this comment.
Could we use perfstat.ProcessStat() from github.com/power-devops/perfstat instead of calling getprocs64 directly? All other AIX cgo implementations in this project (cpu, disk, mem, net) use perfstat, and len(perfstat.ProcessStat()) would give the process count without needing direct CGO/unsafe calls. This would also keep the implementation consistent with the rest of the codebase.
Contributor
Author
|
@shirou yes good catch ! Updated ! |
shirou
approved these changes
Mar 13, 2026
Owner
shirou
left a comment
shirou
left a comment
There was a problem hiding this comment.
Thank you for the update! LGTM!
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an implementation of
numProcson AIX usinggetprocs64.https://www.ibm.com/docs/en/aix/7.2.0?topic=g-getprocs-subroutine
Similarly to #2019, it just iterates over processes with
getprocs64, one at a time, and could be optimized.