Merged
Conversation
shirou
approved these changes
Mar 13, 2026
Owner
shirou
left a comment
There was a problem hiding this comment.
LGTM. Directly assigning the string fields makes the parsing simpler and more robust. Thanks!
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of
wlooks like that:For some reason the current version tries to
ParseFloattheUserandttyfields, which are strings, so it fails and doesn't fill them. The PR fixes this by assigning directly the value to the fields.Note: the
login@column could be mapped to theStartedfield, but it would require parsing the value and knowing the date and timezone.