Skip to content

Use total stats for AIX CPU times#2014

Merged
shirou merged 1 commit intoshirou:masterfrom
pgimalac:pgimalac/aix-cpu-total-stats
Mar 7, 2026
Merged

Use total stats for AIX CPU times#2014
shirou merged 1 commit intoshirou:masterfrom
pgimalac:pgimalac/aix-cpu-total-stats

Conversation

@pgimalac
Copy link
Copy Markdown
Contributor

@pgimalac pgimalac commented Mar 6, 2026

The current implementation uses Pct fields from CpuUtilTotalStat(), so the values are percentages, which is not aligned with other OSes, which return durations.
CpuTotalStat() is the correct source to get duration values.

https://github.com/power-devops/perfstat/blob/main/types_cpu.go
https://www.ibm.com/docs/ko/aix/7.1.0?topic=interfaces-perfstat-cpu-total-interface

@pgimalac pgimalac marked this pull request as ready for review March 6, 2026 14:08
Copy link
Copy Markdown
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix — returning percentages instead of duration was clearly a bug. This now aligns with the per-CPU branch and other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants