Fix windows open files with context#1991
Merged
shirou merged 2 commits intoshirou:masterfrom Jan 14, 2026
Merged
Conversation
shirou
approved these changes
Jan 14, 2026
Owner
shirou
left a comment
shirou
left a comment
There was a problem hiding this comment.
Great catch! Thank you for your contribution!
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a goroutine is stuck when context is done in Windows
OpenFilesWithContext(ctx context.Context)implementation.Current
TestOpenFilesunit test is covering the new lines with success.