fix disk.Partition cut off after first disk

[sni]

using windows.UTF16ToString() converts a []uint16 to a string but ends after the first NUL. There is already a split0() function which does the right thing in this file, so simply use that one.

before:

getLogicalDrives() -> ['C:\']

after:

getLogicalDrives() -> ['C:\', 'D:\', 'Z:\']

[StefanoBalzarottiNozomi]

@sni thank you so much for the fix, can you please add a test?

[sni]

There are tests in place and they failed on my machine before this fix.
The problem is not the test coverage here.

[StefanoBalzarottiNozomi]

There are tests in place and they failed on my machine before this fix.
The problem is not the test coverage here.
Ok, I still think we have to find a determistic way to test this but your PR is fine for me.
Lets wait for @shirou

[shirou]

Since procGetLogicalDriveStringsW returns device-dependent values, it’s difficult to add tests. Could you share the value of lpBuffer on your local machine? That would help us add tests for split0.

[StefanoBalzarottiNozomi]

Since procGetLogicalDriveStringsW returns device-dependent values, it’s difficult to add tests. Could you share the value of lpBuffer on your local machine? That would help us add tests for split0.

Yeah, but it's possible for example to mount a folder as volume or simulate a virtual drive in the test. It would be nice to know the value and the cause of the problem reported by @sni

[sni]

Could you share the value of lpBuffer on your local machine? That would help us add tests for split0.

Sure, bufferLen is set to: 0xd (13) and lpBuffer is set to:
[]uint16{0x43, 0x3a, 0x5c, 0x0, 0x44, 0x3a, 0x5c, 0x0, 0x5a, 0x3a, 0x5c, 0x0, 0x0}

[shirou]

Thank you for the information! I can confirm that this PR fixes the issue. I’ll create another PR to add tests using virtual drives (possibly with subst).