[sensors][darwin]: retrieve sensor information in one function call#1973
Merged
shirou merged 2 commits intoshirou:masterfrom Dec 25, 2025
Merged
[sensors][darwin]: retrieve sensor information in one function call#1973shirou merged 2 commits intoshirou:masterfrom
shirou merged 2 commits intoshirou:masterfrom
Conversation
uubulb
force-pushed
the
sensors/get_sensor_info_in_one_call
branch
from
048e641 to
19adc40
Compare
uubulb
force-pushed
the
sensors/get_sensor_info_in_one_call
branch
from
19adc40 to
d5e4f0a
Compare
shirou
requested changes
Dec 24, 2025
Owner
shirou
left a comment
shirou
left a comment
There was a problem hiding this comment.
It looks good refactoring. But could you check my comments? Thanks!
shirou
approved these changes
Dec 25, 2025
Owner
shirou
left a comment
shirou
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
getSensorsfunction retrieves both sensor names and temperature metrics in a single call, avoiding the need to invokeioHIDEventSystemClientCopyServicestwice. It also performs deduplication internally, removing the need for a separate helper function.Additionally, some code in the
processpackage was refactored for readability. These changes are mostly equivalent in behavior and should not affect testing results.