Add NumFDs implementation for Darwin#1965
Merged
shirou merged 3 commits intoshirou:masterfrom Dec 13, 2025
Merged
Conversation
shirou
approved these changes
Dec 13, 2025
Owner
shirou
left a comment
There was a problem hiding this comment.
Looks great overall! Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
NumFDs()for macOS using theproc_pidinfosyscall withPROC_PIDLISTFDS.Changes
NumFDsWithContext()implementation for Darwin inprocess_darwin.goPROC_PIDLISTFDSconstant tocommon_darwin.goNumFDsWithContextstub fromprocess_bsd.goto OS-specific filesTesting