Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows, read all PIDs if there are more than 1024 PIDs. #1580

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Windows, read all PIDs if there are more than 1024 PIDs. #1580

merged 1 commit into from
Jan 19, 2024

Conversation

jnewmano
Copy link
Contributor

Convert bytes read to number of uint32s that were read.

@jnewmano
Windows, read all pids if there are more than 1024 pids.
15f7946 
Convert bytes read to number of uint32s that were read.
shirou
shirou approved these changes Jan 19, 2024
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thank you for your contribution!

@shirou shirou merged commit e912ebd into shirou:master Jan 19, 2024
19 checks passed
@Lomanic
Copy link
Collaborator

Lomanic commented Jan 20, 2024

This amends #454, confirmed with the test I described there (replacing the 1024 magic numbers with a small value, like 32, and adding some debug in the loop logging psSize to see it increase). I'm not sure to understand why my test worked at the time, in the meantime the w32 dependency was removed, but it doesn't look suspicious? Anyway, thanks for fixing this long standing bug @jnewmano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnewmano @Lomanic @shirou