Change uploading condition in build workflow, etc.#611
Merged
shirok merged 1 commit intoshirok:masterfrom Feb 27, 2020
Merged
Conversation
Owner
|
ども。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
タイムアウトでの終了は、failure ではなく cancel 扱いになるらしく、
結局、ログが取れませんでした。。。
( https://github.com/Hamayama/Gauche/actions/runs/45007857 )
このため、if: の条件を always() に変更しました。
また、Windows で gosh.exe が存在しないとなる件ですが、
「msiexec が非同期に実行されるため」という情報があったため、対応しました。
( https://devblogs.microsoft.com/setup/waiting-for-msiexec-exe-to-finish/ )
<テスト結果>
https://github.com/Hamayama/Gauche/actions/runs/46039773
<関連情報>
https://practical-scheme.net/wiliki/wiliki.cgi?Gauche%3ABugs#H-1qgtcx1
https://gist.github.com/Hamayama/3cc0e9c0c5283e7fc422360c6e5bd372
関連プルリクエスト #601 #603 #605 #606 #608