Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified plugin configuration by making readOnlyToken optional #48

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

slawekjaranowski
Copy link
Contributor

@slawekjaranowski slawekjaranowski commented Dec 9, 2020

Fixes #47

No it is optional to explicitly specify the readOnlyToken.

slawekjaranowski and others added 2 commits December 9, 2020 23:40
- randomized GH auth token to avoid proliferation of a real token (that is my personal token)
- clarified the default
Copy link
Contributor

@mockitoguy mockitoguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mockitoguy mockitoguy changed the title Allow empty readOnlyToke Simplified plugin configuration by making readOnlyToken optional Dec 10, 2020
@mockitoguy mockitoguy merged commit c78c904 into shipkit:master Dec 10, 2020
@mockitoguy
Copy link
Contributor

Hey @slawekjaranowski, do you want to be a contributor to the Shipkit plugins? The high level goal for the plugins is to be awesome and have thousands of happy customers / thousands of GH stars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty readOnlyToken
2 participants