"Execution optimizations have been disabled" Warning on Gradle >= 7 #103
Comments
@Internal
public File getWorkingDir() {
return workingDir;
}
public void setWorkingDir(File workingDir) {
this.workingDir = workingDir;
}
@InputDirectory
@Optional
public File getInputGitDirectory() {
if (workingDir != null) {
File dotGitDirectory = new File(workingDir, ".git");
if (dotGitDirectory.isDirectory()) {
return dotGitDirectory;
}
}
return null;
}Works as a workaround which allows not changing the existing API, but I don't like it. It's probably best if it doesn't take the root project directory as an input property at all? In my custom changelog task I take just the relevant git refs folder: @InputDirectory
@PathSensitive(PathSensitivity.RELATIVE)
public abstract DirectoryProperty getGitRefs();
... { getGitRefs().convention(objectFactory.directoryProperty().fileValue(new File(".git/refs/"))); } |
|
|
|
I needed to add this to my build for it to work on Gradle 8: tasks.generateChangelog {
// ...
doNotTrackState("GenerateChangelogTask incorrectly depends on entire working dir, see https://github.com/shipkit/shipkit-changelog/issues/103")
dependsOn(tasks.assemble) // Same as above
}Otherwise, the build fails with one of two exceptions: |
magneticflux-
pushed a commit
to magneticflux-/shipkit-changelog
that referenced
this issue
Mar 29, 2023
|
Mockito master is now broken because of this too... cc @TimvdLippe https://github.com/mockito/mockito/actions/runs/5457593285/jobs/9931914322 I'll try the workaround mentioned above to keep releasing now that the build is on Gradle 8.x. @shipkit please merge the PR associated here. |
8 tasks
|
@mockitoguy can you please take a look? |
TWiStErRob
added a commit
to TWiStErRob/mockito
that referenced
this issue
Jul 5, 2023
8 tasks
|
It's not enough to just depend on // GenerateChangelogTask uses the entire repo as input, which means it needs to "depend on" all other tasks' outputs.
mustRunAfter(allprojects.collectMany { it.tasks }.grep { it.path != ":generateChangelog" && it.path != ":githubRelease" })This also has a very sad side effect of realizing every task, luckily the mockito repo is not migrated to be lazy configured yet. |
TimvdLippe
pushed a commit
to mockito/mockito
that referenced
this issue
Jul 5, 2023
* Fix test framework dependencies. > Task :extTest:test The automatic loading of test framework implementation dependencies has been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the desired test framework directly on the test suite or explicitly declare the test framework implementation dependencies on the test's runtime classpath. Consult the upgrading guide for further information: https://docs.gradle.org/8.2/userguide/upgrading_version_8.html#test_framework_implementation_dependencies * Work around shipkit/shipkit-changelog#103
|
Looking. Thanks everyone! |
mockitoguy
added a commit
that referenced
this issue
Jan 24, 2024
This was referenced Jan 24, 2024
TWiStErRob
added a commit
to TWiStErRob/mockito
that referenced
this issue
Jan 27, 2024
Reverts part of mockito#3053
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An example of the warnings:
And the full log: https://github.com/magneticflux-/jetpack-compose-optics/runs/2769627239#step:5:38
Maybe only the
.gitfolder should be provided as input?The text was updated successfully, but these errors were encountered: