Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): search parameters adjustments #296

Merged
merged 1 commit into from
May 9, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented May 9, 2024

The changes in this PR are the following:

  • We no longer add empty variable in search query
  • Refresh interval is no longer depending on query, it's saved in local storage

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (af2cb29) to head (6a6fac0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files          26       26           
  Lines        1822     1822           
=======================================
  Hits          974      974           
  Misses        757      757           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i merged commit 7b569f7 into main May 9, 2024
5 checks passed
@shini4i shini4i deleted the chore/frontend-update-search-parameters branch May 9, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant