Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for providing override file name #261

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Mar 18, 2024

Closes #260

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 51.05%. Comparing base (4ae69fa) to head (b471d8a).

Files Patch % Lines
pkg/updater/updater.go 55.55% 4 Missing ⚠️
internal/models/argo.go 0.00% 1 Missing ⚠️
internal/models/gitops.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   50.97%   51.05%   +0.08%     
==========================================
  Files          25       25              
  Lines        1642     1657      +15     
==========================================
+ Hits          837      846       +9     
- Misses        732      738       +6     
  Partials       73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i merged commit 4e262bf into main Mar 18, 2024
4 checks passed
@shini4i shini4i deleted the chore/write-back-target-override branch March 18, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support to change override file name via annotation
1 participant