Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keycloak): simplify redeploy logic #239

Merged
merged 9 commits into from
Jan 22, 2024
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Jan 19, 2024

This PR removes the necessity to provide deploy tokens in the front end.

Now, we only prompt the user for basic confirmation:
Screenshot 2024-01-19 at 13 57 47

Additionally, the "ROLLBACK TO THIS VERSION" button is no longer active while the task status is "in progress":
Screenshot 2024-01-19 at 13 56 41

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (6d0c078) 53.34% compared to head (1653f8a) 53.24%.

Files Patch % Lines
cmd/argo-watcher/server/router.go 0.00% 15 Missing ⚠️
cmd/argo-watcher/auth/keycloak.go 74.46% 7 Missing and 5 partials ⚠️
cmd/argo-watcher/server/server.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   53.34%   53.24%   -0.11%     
==========================================
  Files          18       20       +2     
  Lines        1331     1403      +72     
==========================================
+ Hits          710      747      +37     
- Misses        556      586      +30     
- Partials       65       70       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i merged commit b5f55c2 into main Jan 22, 2024
2 of 4 checks passed
@shini4i shini4i deleted the chore/keycloak-adjustments branch January 22, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant