Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly process degraded applications #225

Merged
merged 19 commits into from
Dec 6, 2023
Merged

fix: correctly process degraded applications #225

merged 19 commits into from
Dec 6, 2023

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Nov 30, 2023 •
edited
Loading

Closes #222

@shini4i
Copy link
Owner Author

shini4i commented Nov 30, 2023

I'm not sure if this approach is reasonable enough. The main struggle is to correctly handle applications that were initially degraded. What do you think @bozerkins?

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (7a10925) 53.03% compared to head (ab443d3) 53.34%.

Files Patch % Lines
cmd/argo-watcher/argo_status_updater.go 64.70% 10 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   53.03%   53.34%   +0.31%     
==========================================
  Files          18       18              
  Lines        1303     1331      +28     
==========================================
+ Hits          691      710      +19     
- Misses        548      556       +8     
- Partials       64       65       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i marked this pull request as ready for review December 5, 2023 08:18
bozerkins
bozerkins previously approved these changes Dec 5, 2023
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shini4i shini4i merged commit 68bd376 into main Dec 6, 2023
5 checks passed
@shini4i shini4i deleted the chore/handle-degraded-app branch December 6, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozerkins bozerkins bozerkins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop processing task if application reached degraded state
2 participants
@shini4i @bozerkins