Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor client changes #221

Merged
merged 9 commits into from
Nov 22, 2023
Merged

chore: minor client changes #221

merged 9 commits into from
Nov 22, 2023

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Nov 21, 2023

Improve logging, and increase test coverage

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (d518f67) 49.18% compared to head (0bae31f) 50.19%.

Files Patch % Lines
pkg/client/client.go 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   49.18%   50.19%   +1.00%     
==========================================
  Files          18       18              
  Lines        1291     1303      +12     
==========================================
+ Hits          635      654      +19     
+ Misses        587      584       -3     
+ Partials       69       65       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i changed the title chore: client logs improvement chore: minor client changes Nov 21, 2023
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shini4i shini4i merged commit b477b8c into main Nov 22, 2023
5 of 6 checks passed
@shini4i shini4i deleted the chore/client-logging-adjustment branch November 22, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant