Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): small refactoring and additional debug information #210

Merged
merged 10 commits into from
Oct 19, 2023

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Oct 16, 2023

Closes #147

@shini4i shini4i changed the title chore: initial prep for client refactoring chore(client): small refactoring and additional debug information Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #210 (ebd291d) into main (f5e01cc) will increase coverage by 0.18%.
The diff coverage is 32.96%.

❗ Current head ebd291d differs from pull request most recent head 5172f3b. Consider uploading reports for the commit 5172f3b to get more accurate results

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   45.20%   45.38%   +0.18%     
==========================================
  Files          16       16              
  Lines        1210     1247      +37     
==========================================
+ Hits          547      566      +19     
- Misses        599      614      +15     
- Partials       64       67       +3     
Files Coverage Δ
internal/models/task.go 100.00% <ø> (ø)
cmd/argo-watcher/server.go 15.68% <0.00%> (ø)
cmd/argo-watcher/main.go 16.66% <0.00%> (ø)
internal/helpers/helpers.go 91.66% <85.71%> (-8.34%) ⬇️
pkg/client/client.go 23.94% <17.91%> (-2.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shini4i shini4i marked this pull request as ready for review October 19, 2023 18:59
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shini4i shini4i merged commit 0c50786 into main Oct 19, 2023
4 checks passed
@shini4i shini4i deleted the chore/client-refactoring branch October 19, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add more debug information to the clients output
1 participant