chore(config): replace unmaintained envconfig #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 46.01% 46.19% +0.18%
==========================================
Files 16 16
Lines 1230 1223 -7
==========================================
- Hits 566 565 -1
+ Misses 602 596 -6
Partials 62 62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
|
Kudos, SonarCloud Quality Gate passed!
|
bozerkins
reviewed
Sep 8, 2023
| @@ -72,7 +73,8 @@ func init() { | |||
| mux.HandleFunc("/api/v1/session/userinfo", getUserInfoHandler) | |||
| mux.HandleFunc("/api/v1/applications/test", getApplicationHandler) | |||
| server = httptest.NewServer(mux) | |||
| api = &ArgoApi{baseUrl: server.URL, client: server.Client()} | |||
| parsedURL, _ := url.Parse(server.URL) // we assume that the server.URL is valid | |||
There was a problem hiding this comment.
We might want to not assume, but throw errors here
There was a problem hiding this comment.
It is a URL coming from the default library, If it will return an invalid url it would be the least of our problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace unmaintained
kelseyhightower/envconfigwith maintainedcaarlos0/env, and move some logic toenvConfig.Parse.