Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): add basic golangci-lint setup #162

Merged
merged 8 commits into from
Jul 25, 2023
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Jul 19, 2023

This PR incorporates the following changes:

  1. Initial setup of golangci-lint was added
  2. Concerns raised by golangci-lint were addressed
  3. gomock was replaced with maintained fork

@shini4i shini4i changed the title feat: add basic golangci-lint setup feat(workflows): add basic golangci-lint setup Jul 19, 2023
cmd/argo-watcher/server.go Show resolved Hide resolved
@shini4i shini4i requested a review from bozerkins July 21, 2023 07:17
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@shini4i shini4i dismissed bozerkins’s stale review July 25, 2023 14:24

The requested changes were implemented

@shini4i shini4i merged commit e10f327 into main Jul 25, 2023
@shini4i shini4i deleted the feat/add-golangcilint branch July 25, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants