Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve in-memory ProcessObsoleteTasks and add test #153

Merged
merged 3 commits into from
Jul 1, 2023
Merged

chore: improve in-memory ProcessObsoleteTasks and add test #153

merged 3 commits into from
Jul 1, 2023

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Jun 30, 2023

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

@shini4i shini4i requested a review from tomsozolins June 30, 2023 21:41
bozerkins
bozerkins requested changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@bozerkins bozerkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave the error generation where the error happens. The rest looks good.

bozerkins
bozerkins approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@bozerkins bozerkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided that the approach works well with this particular case

@shini4i shini4i merged commit 367af82 into main Jul 1, 2023
@shini4i shini4i deleted the chore/in-memory-state-refactor branch July 1, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozerkins bozerkins bozerkins approved these changes

@rustamar rustamar Awaiting requested review from rustamar

@tomsozolins tomsozolins Awaiting requested review from tomsozolins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shini4i @bozerkins