Add HiDPI scaling support for high resolution displays #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional --hidpi configure flag to allow installing as a fully SVG theme, with an updated index.theme for HiDPI support. This will be seen when Scaling is set to 2x or 3x. Fixes issues where wrong icons are shown in some places with scaling enabled (like the Places sidebars in file managers), and blurry icon issues, especially with scaling enabled. The PNG non-HiDPI theme also restricted the amount of zoom steps the icons had with scaling enabled, so this should resolve that as well. Fixes shimmerproject#124 Fixes shimmerproject#317 Fixes shimmerproject#362 Fixes shimmerproject#403
|
Gah, I had to fix an error in the name of the index file. Sorry if that caused any problems to anyone. Also, I should've added the command is:
|
|
Replacing this with #476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ochosi and @bluesabre, would you all be able to take a look at this HiDPI/Scaling option (and test it out)?
There was some question as to whether we should stay PNG or go SVG, so I thought an option for SVG would be a good compromise.
I would like to know if this method would work for distro-packaging. Would this allow the HiDPI version to be installable as a separate package?
Or should the SVG version of the theme just be installed as an extra theme (like elementary-xfce-dark)? This would increase package size.
Xfce added some icon scaling support in 4.18 and with 4.20 it will be supported throught the DE. The PNG theme won't work well for people who enable scaling (In xfce4-appearance > Settings > Window Scaling). So I'd like to work on some initial solution.
Anyway, I'd appreciate it if you all could take a look and let me know if this works or what I can do to make it work better. Thanks!
Add an optional --hidpi configure flag to allow installing as a fully SVG theme, with an updated index.theme for HiDPI support. This will be seen when Scaling is set to 2x or 3x.
Fixes issues where wrong icons are shown in some places with scaling enabled (like the Places sidebars in file managers), and blurry icon issues, especially with scaling enabled. The PNG non-HiDPI theme also restricted the amount of zoom steps the icons had with scaling enabled, so this should resolve that as well.
Fixes #124
Fixes #317
Fixes #362
Fixes #403