Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations: Add VPN "connecting" icons at 16px #400

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Sep 10, 2023

If this style is okay, I'd like to update other sizes to match (in a future PR).

Add symbolic "connecting" icons seen when trying to connect to a VPN.

Add/Update non-symbolic icons to match, use blue color to avoid needing monochrome icons for light and dark themes.

Icons from Papirus/Paper icon themes, updated AUTHORS with licensing and links.

Add symbolic "connecting" icons seen when
trying to connect to a VPN.

Update non-symbolic icons to match, use blue color to
avoid needing monochrome icons for light and dark themes.

Icons from Papirus/Paper icon themes, updated AUTHORS with
licensing and links.
@ochosi
Copy link
Member

ochosi commented Oct 10, 2023

These look good and seem to fit the overall style of the theme well. Does upstream not show any animation for VPN connection?

@newhoa
Copy link
Contributor Author

newhoa commented Oct 10, 2023

These look good and seem to fit the overall style of the theme well. Does upstream not show any animation for VPN connection?

The only icon upstream has for animations is process-working process-working-symbolic . It looks like VPN icons were removed because their app provides them (they've been removing a lot of icons for this reason over the last year or so, so it's hard to check all their apps for icons). But it looks like no animations are used for their wingpanel indicator, only a placeholder shield icon. The network animations here are for the network-manager/nm-applet which upstream doesn't support.

Copy link
Member

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's pull them in then!

@ochosi ochosi merged commit 78659b0 into shimmerproject:master Oct 14, 2023
1 check passed
@newhoa newhoa deleted the nm-connecting-animation branch March 11, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants