Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert 'symbolic-rtl' versions. #394

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Do not convert 'symbolic-rtl' versions. #394

merged 1 commit into from
Oct 10, 2023

Conversation

madpilot78
Copy link
Contributor

While updating the FreeBSD port I got failures due to cp failing to find some files, referenced by symlinks:

install -d /wrkdirs/usr/ports/x11-themes/xfce-icons-elementary/work/stage/usr/local/share/icons
cp -rf build/elementary-xfce /wrkdirs/usr/ports/x11-themes/xfce-icons-elementary/work/stage/usr/local/share/icons
cp: build/elementary-xfce/actions/24/go-previous-symbolic-rtl.png: No such file or directory
cp: build/elementary-xfce/actions/24/media-skip-forward-symbolic-rtl.png: No such file or directory
cp: build/elementary-xfce/actions/24/media-skip-backward-symbolic-rtl.png: No such file or directory
cp: build/elementary-xfce/actions/24/go-next-symbolic-rtl.png: No such file or directory
cp: build/elementary-xfce/actions/24/media-seek-forward-symbolic-rtl.png: No such file or directory
cp: build/elementary-xfce/actions/24/media-seek-backward-symbolic-rtl.png: No such file or directory
*** Error code 1

Looks like some finles with a new namiong scheme (*-symbolic-rtl.svn) have been added in commit 1c135ad but the expressions in the svgtopng/pngtheme.sh script have not been updated to account for this.

This is the fix I'm using in the FreeBSD ports tree.

vishwin pushed a commit to vishwin/freebsd-ports that referenced this pull request Sep 6, 2023
Copy link
Member

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fix!

@ochosi ochosi merged commit bed04b3 into shimmerproject:master Oct 10, 2023
1 check passed
@madpilot78 madpilot78 deleted the BuildFix branch October 10, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants