Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps: Refresh software center icons #382

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Jul 9, 2023

User newer elementary gradients, borders, and arrow styles for org.gnome.Software and system-software-installer.

Split this one off from #344 as I think these are pretty uncontroversial. (any input on the discussion in #344 would be appreciated!)

Current (screenshots taken before softwarecenter changed to org.gnome.Software):
software-installer-current1

Proposed:
software-installer-prop1

Oh, also, many app icons are symlinked to system-software-installer, which means they all use the same icon. Is this okay?

software-installer-symlinks

@ochosi
Copy link
Member

ochosi commented Jul 14, 2023

Urgh, I accidentally didn't rebase the branch and now there's a merge commit - sorry 🙄

Could you rebase on top of master please?

Otherwise it looks good to me and ready to go in!

User newer elementary gradients, borders, and arrow styles
for `org.gnome.Software` and `system-software-installer`.
@newhoa newhoa force-pushed the software-app-icon-refresh branch from c5875d3 to dafa8f2 Compare July 14, 2023 16:09
@newhoa
Copy link
Contributor Author

newhoa commented Jul 14, 2023

Urgh, I accidentally didn't rebase the branch and now there's a merge commit - sorry roll_eyes

Could you rebase on top of master please?

Otherwise it looks good to me and ready to go in!

Haha, I accidentally did the same with a few PRs. I think Github changed the "Update" button? Now it merge commits by default and makes you click the dropdown for rebase. Really annoying.

Anyway, rebased and should be okay. Thanks!

Copy link
Member

@bluesabre bluesabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and Simon already signed off too.

@bluesabre bluesabre merged commit b45f208 into shimmerproject:master Sep 6, 2023
1 check passed
@newhoa newhoa deleted the software-app-icon-refresh branch September 8, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants