-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct gradients for horizontal scrollbars #288
Conversation
&:hover { | ||
background-image: linear-gradient(to bottom, | ||
darken($scrollbar_slider_color, 5%), | ||
darken($scrollbar_slider_color, 1%)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable scrollbar_slider_color
should be written in all lowercase letters with hyphens instead of underscores
lighten($scrollbar_slider_color, 1%)); | ||
&:hover { | ||
background-image: linear-gradient(to bottom, | ||
darken($scrollbar_slider_color, 5%), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable scrollbar_slider_color
should be written in all lowercase letters with hyphens instead of underscores
slider { | ||
background-image: linear-gradient(to bottom, | ||
lighten($scrollbar_slider_color, 5%), | ||
lighten($scrollbar_slider_color, 1%)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable scrollbar_slider_color
should be written in all lowercase letters with hyphens instead of underscores
lighten($scrollbar_slider_color, 1%)); | ||
&:hover { | ||
background-image: linear-gradient(to right, | ||
darken($scrollbar_slider_color, 5%), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable scrollbar_slider_color
should be written in all lowercase letters with hyphens instead of underscores
slider { | ||
background-image: linear-gradient(to right, | ||
lighten($scrollbar_slider_color, 5%), | ||
lighten($scrollbar_slider_color, 1%)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable scrollbar_slider_color
should be written in all lowercase letters with hyphens instead of underscores
); | ||
slider { | ||
background-image: linear-gradient(to right, | ||
lighten($scrollbar_slider_color, 5%), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable scrollbar_slider_color
should be written in all lowercase letters with hyphens instead of underscores
&.vertical { | ||
background-image: linear-gradient(to right, | ||
lighten($bg_color, 10%), | ||
lighten($bg_color, 30%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable bg_color
should be written in all lowercase letters with hyphens instead of underscores
); | ||
&.vertical { | ||
background-image: linear-gradient(to right, | ||
lighten($bg_color, 10%), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable bg_color
should be written in all lowercase letters with hyphens instead of underscores
Crazy that nobody noticed this so far - this issue must be around for ages :) |
I noticed that horizontal and vertical scrollbars are both colored with horizontal gradients, which causes the vertical scrollbars to have a raised 3d appearance, while the horizontal scrollbars appear smooth.
This PR changes the horizontal scrollbars to use vertical gradients, so both types of scrollbar appear the same.
Before:
After: