Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct gradients for horizontal scrollbars #288

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

thal
Copy link
Contributor

@thal thal commented Dec 1, 2020

I noticed that horizontal and vertical scrollbars are both colored with horizontal gradients, which causes the vertical scrollbars to have a raised 3d appearance, while the horizontal scrollbars appear smooth.

This PR changes the horizontal scrollbars to use vertical gradients, so both types of scrollbar appear the same.

Before:

before

After:

after

light/gtk-3.0/_common.scss Show resolved Hide resolved
&:hover {
background-image: linear-gradient(to bottom,
darken($scrollbar_slider_color, 5%),
darken($scrollbar_slider_color, 1%));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable scrollbar_slider_color should be written in all lowercase letters with hyphens instead of underscores

lighten($scrollbar_slider_color, 1%));
&:hover {
background-image: linear-gradient(to bottom,
darken($scrollbar_slider_color, 5%),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable scrollbar_slider_color should be written in all lowercase letters with hyphens instead of underscores

light/gtk-3.0/_common.scss Show resolved Hide resolved
slider {
background-image: linear-gradient(to bottom,
lighten($scrollbar_slider_color, 5%),
lighten($scrollbar_slider_color, 1%));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable scrollbar_slider_color should be written in all lowercase letters with hyphens instead of underscores

lighten($scrollbar_slider_color, 1%));
&:hover {
background-image: linear-gradient(to right,
darken($scrollbar_slider_color, 5%),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable scrollbar_slider_color should be written in all lowercase letters with hyphens instead of underscores

light/gtk-3.0/_common.scss Show resolved Hide resolved
slider {
background-image: linear-gradient(to right,
lighten($scrollbar_slider_color, 5%),
lighten($scrollbar_slider_color, 1%));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable scrollbar_slider_color should be written in all lowercase letters with hyphens instead of underscores

);
slider {
background-image: linear-gradient(to right,
lighten($scrollbar_slider_color, 5%),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable scrollbar_slider_color should be written in all lowercase letters with hyphens instead of underscores

light/gtk-3.0/_common.scss Show resolved Hide resolved
&.vertical {
background-image: linear-gradient(to right,
lighten($bg_color, 10%),
lighten($bg_color, 30%)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable bg_color should be written in all lowercase letters with hyphens instead of underscores

);
&.vertical {
background-image: linear-gradient(to right,
lighten($bg_color, 10%),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable bg_color should be written in all lowercase letters with hyphens instead of underscores

@ochosi
Copy link
Member

ochosi commented Dec 1, 2020

Crazy that nobody noticed this so far - this issue must be around for ages :)
Thanks for looking into a fix, i'll try to review as soon as possible.

@ochosi ochosi merged commit 2548ad1 into shimmerproject:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants