Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop down menus not rendering properly #265

Closed
abhprk32 opened this issue Apr 4, 2020 · 21 comments
Closed

Drop down menus not rendering properly #265

abhprk32 opened this issue Apr 4, 2020 · 21 comments

Comments

@abhprk32
Copy link

abhprk32 commented Apr 4, 2020

Screenshot_2020-04-04_12-04-50
OS- arch linux xfce 4.14

@nonamedotc
Copy link

I suspect this is not just drop-down menus. Please see this screenshot.

This is on Fedora 32, xfce 4.14.

gtk3-3.24.16
greybird-light-theme-3.22.12

greybird

@ochosi
Copy link
Member

ochosi commented Apr 11, 2020

Ok wow, I need to check if I can reproduce that...

@m4u9
Copy link
Member

m4u9 commented Apr 11, 2020

I'm unable to reproduce this in openSUSE Tumbleweed.
gtk3-3.24.16

could this be a fedora packaging issue?

@nonamedotc
Copy link

could this be a fedora packaging issue?

Could be except first comment shows similar issue in Arch - unless these are unrelated issues.

@abhprk32
Copy link
Author

I'm unable to reproduce this in openSUSE Tumbleweed.
gtk3-3.24.16

could this be a fedora packaging issue?

I dont think so. I also tried changing fonts to check if my font settings were messing up some thing or not but it doesnt works.

@notarun
Copy link

notarun commented Apr 11, 2020

Can reproduce this on Arch using gtk 3.24.17

2020-04-12_04-39

@notarun
Copy link

notarun commented Apr 14, 2020

So, I came up with a hack to fix this issue. It only fixes styling for combo boxes and some buttons in header bar. Issue still persists in path bar.

.horizontal.linked > button:last-child {
  border-right-style: solid;
  border-right-width: 1px;
}

2020-04-14_22-54

If someone can guide me on the pathbar issue I will be able to make a pull request.

@birdie-github
Copy link

birdie-github commented May 6, 2020

Fedora 32 - confirming.

greybird2

I've downgraded to version 3.22.10 which works just fine.

@birdie-github
Copy link

birdie-github commented May 22, 2020

Buttons are affected as well.

logout

Fedora 32.

gtk3-3.24.20-1.fc32.x86_64
greybird-dark-theme-3.22.12-1.fc32.noarch
greybird-light-theme-3.22.12-1.fc32.noarch

@winterwolf
Copy link

winterwolf commented May 25, 2020

Thanks @notarun, I added this rule to other elements:

.horizontal.linked > entry:last-child,
.horizontal.linked > button:last-child,
.path-bar > button:last-child {
  border-right-style: solid;
  border-right-width: 1px;
}

@ochosi
Copy link
Member

ochosi commented Jun 9, 2020

Your workaround points to the fact that for whatever reason these comboboxes get the "linked" class (which they shouldn't, because they are all alone in the world).

I also looked into Adwaita and couldn't find a related change. I presume you cannot reproduce this problem with Adwaita, correct?

@andreldm
Copy link
Contributor

andreldm commented Jun 9, 2020

No, I can't:
image

gtk 3.24.20, Arch Linux

@philipzae
Copy link

Reproduced in xfce-test built yesterday.

@skontar
Copy link

skontar commented Aug 3, 2020

So I have just tested it on Fedora 32 as I have also noticed the problem. Last correctly working release is 3.22.10, I have just downloaded 3.22.10 and 3.22.11 and built them locally.

@m4u9
Copy link
Member

m4u9 commented Aug 3, 2020

@skontar could you please also test git master?

@skontar
Copy link

skontar commented Aug 3, 2020

@m4u9 I did just now. No change. (Meaning the problem is still visible.)

@ochosi
Copy link
Member

ochosi commented Aug 21, 2020

Reproduced in xfce-test built yesterday.

@philipzae Did you use a tag built on travis or build locally?

@philipzae
Copy link

Reproduced in xfce-test built yesterday.

@philipzae Did you use a tag built on travis or build locally?

I used the xfce-test docker container that was built on july 22nd.

@ochosi
Copy link
Member

ochosi commented Aug 30, 2020

Right, but which tag? latest?

@philipzae
Copy link

yes latest

@skontar
Copy link

skontar commented Nov 2, 2020

Interestingly enough, today I have installed Fedora 33 on another system and built 3.22.10 as I have tested it some time ago in Fedora 32 and it worked. It shows the same problem. Adwaita is still fine. Not sure if that helps at all 🤷.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants