Xfwm 4.13.1 tabwin as list too sparse

[andreldm]

Until now Xfwm 4.13.1 tabwin was missing proper Greybird style, it looks great when using the default icon mode, but when "Cycle through windows in a list" is enabled in Window Manager Tweaks, it looks too sparse:

[ochosi]

Oh my, I guess I would have to patch Xfwm4 to properly fix this...

Currently there is no meaningful way to distinguish the list and the normal style, at least not in CSS. I will take a look at Xfwm4 I guess.

[andreldm]

I don't think so, you just forgot about listview-icon-size, all you need is to add -XfwmTabwinWidget-listview-icon-size: 24px; to #xfwm-tabwin.

[andreldm]

Oh, min-width and min-height in #xfwm-tabwin button need to be removed or decreased to 24px.

[ochosi]

Yeah, I know and that's not a very nice solution. It would be nicer if Xfwm4 would set an additional styleclass dynamically when the list mode is in use

[andreldm]

Both properties (icon-size and listview-icon-size) are used in the gtk2 version of Greybird, I fail to see how this is not a nice solution for gtk3. At least both modes now look fine to me.
I know styleclasses would be safer and simple to introduce in xfwm4, but is it really necessary?

[ochosi]

If you want to use something like min-height, then yes. Personally I like that in Gtk3 I can make those buttons a tad bigger and enforce squareness.

[andreldm]

Upstream bug: https://bugzilla.xfce.org/show_bug.cgi?id=14635

[ochosi]

Until we get this fixed in Xfwm4 I don't want to leave everyone using Xfwm4 with listview and Greybird in the rain. I can always re-introduce this style again later.

[andreldm]

That patch landed in xfwm4 master:
https://git.xfce.org/xfce/xfwm4/commit/?id=66e742dcd2ffee961f4e75d0f4a7fec329d70337

[ochosi]

Thanks @andreldm, I'll take a look at this again soon.

[ochosi]

Works nicely with git master! Thanks for the patch.