Migrate Windows CI to Visual Studio 2026 - #1897
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe Windows GitHub Actions workflow updates the CMake ChangesVisual Studio 2026 Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
windows-11-arm still ships Visual Studio 2022, so the "Visual Studio 18 2026" generator fails with "could not find any instance of Visual Studio". Only the x64 windows-2025 image has migrated to VS 2026. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
OpenCvSharpExtern.dll is built with the static CRT (/MT), and the prebuilt opencv_videoio_ffmpeg DLL depends only on the OS-bundled msvcrt.dll. Neither links vcruntime140/msvcp140, so the Visual C++ Redistributable is not required. Verified with dumpbin /dependents. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The
windows-2025runner image replaced Visual Studio 2022 with Visual Studio 2026, so the hardcoded CMake generatorVisual Studio 17 2022now fails with "could not find any instance of Visual Studio".https://github.blog/changelog/2026-05-14-github-actions-upcoming-image-migrations/#windows-2025-visual-studio-2026-image-migration
Update the generator to
Visual Studio 18 2026in all 6 cmake invocations in.github/workflows/windows.yml(x64: OpenCV, Extern full, Extern slim; ARM64: the same three).Summary by CodeRabbit