Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rehype): improve lazy performance #896

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(rehype): improve lazy performance #896

merged 1 commit into from
Jan 20, 2025

Conversation

fuma-nama
Copy link
Contributor

Description

This PR improves the performance of lazy by:

  • Instead of always add tasks to a queue, it highlights nodes in sync if the language is loaded.
  • Only return promise (async) if unloaded language is found.
  • Cleaned some code, and removed one unnecessary function.

Linked Issues

N/A

Additional context

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit b644dfd
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/678bca9e9bc62c000731052b
😎 Deploy Preview https://deploy-preview-896--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit b644dfd
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/678bca9e323e040008bf582b
😎 Deploy Preview https://deploy-preview-896--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu merged commit 5c10f25 into shikijs:main Jan 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants