feat: support rootStyle: false option#1184
Merged
antfu merged 4 commits intoshikijs:mainfrom Dec 3, 2025
Merged
Conversation
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
=======================================
Coverage 95.08% 95.08%
=======================================
Files 91 91
Lines 7866 7868 +2
Branches 1662 1666 +4
=======================================
+ Hits 7479 7481 +2
Misses 381 381
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rootStyle: false option
antfu
approved these changes
Dec 3, 2025
This was referenced Dec 3, 2025
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
rootStyleoption was being ignored when usingcodeToHtmlwith a single theme (e.g.github-light).Previously, codeToTokens returned
rootStyle: undefinedfor single-theme usage, which unintentionally overwrote therootStylepassed in options when calling tokensToHast inside codeToHast. This resulted in the default background color (often white for light themes) being forced, even when the user tried to disable it withrootStyle: falseorrootStyle: ''.The fix involves updating codeToHast to only use the
rootStylefrom codeToTokens if it is defined, otherwise falling back tooptions.rootStyle.Linked Issues
Fixes #1175
Additional context
Verified using the reproduction script provided in the issue.
style="background-color:#fff;color:#24292e"(forced background)style=""(whenrootStyle: ''is passed)