Skip to content

feat(langs): support embeddedLanguages alias for backwards compatibility (#1044)#1145

Merged
antfu merged 1 commit intoshikijs:mainfrom
Ipshita29:feat-embeddedLanguages-alias
Nov 27, 2025
Merged

feat(langs): support embeddedLanguages alias for backwards compatibility (#1044)#1145
antfu merged 1 commit intoshikijs:mainfrom
Ipshita29:feat-embeddedLanguages-alias

Conversation

@Ipshita29
Copy link
Contributor

Description

This PR adds support for the embeddedLanguages field in LanguageRegistration.

Historically the field was named embeddedLangs, while VSCode grammars use embeddedLanguages.
Shiki currently supports only embeddedLangs, which prevents grammars using the VSCode naming convention from working as expected.

Linked Issues

Fixes #1044

Additional context

No breaking changes introduced — if both fields are present, embeddedLanguages takes priority.
This brings Shiki in line with VSCode terminology while preserving support for older grammars.

@netlify
Copy link

netlify bot commented Nov 27, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit c1173b3
🔍 Latest deploy log https://app.netlify.com/projects/shiki-matsu/deploys/6927d95651a584000836a561
😎 Deploy Preview https://deploy-preview-1145--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 27, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit c1173b3
🔍 Latest deploy log https://app.netlify.com/projects/shiki-next/deploys/6927d9560dfdba000801a729
😎 Deploy Preview https://deploy-preview-1145--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.95%. Comparing base (5068b26) to head (c1173b3).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   88.35%   94.95%   +6.60%     
==========================================
  Files          74       90      +16     
  Lines        3322     7777    +4455     
  Branches      956     1632     +676     
==========================================
+ Hits         2935     7385    +4450     
- Misses        344      386      +42     
+ Partials       43        6      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antfu antfu merged commit 3a367d5 into shikijs:main Nov 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why embeddedLangs instead of embeddedLanguages?

2 participants