Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda support by passing on 'token' from configuration to credentials #9

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Lambda support by passing on 'token' from configuration to credentials #9

merged 1 commit into from
Jun 29, 2020

Conversation

danniehansen
Copy link

Hi,

This simple fix, fixes an issue when running this SQS FIFO package on Lambda using something like https://github.com/brefphp/laravel-bridge

When working in Lambda you typically assign privileges to the Lambda function it-self. This means instead of receiving a access key id & secret the Lambda instance have temporary tokens that it pass on to the SDK for authentication. So passing on this token from the configuration side of things allows it to authenticate.

With this you'll be able to run server-less Lambda SQS FIFO handlers.

@mnapoli
Copy link

mnapoli commented Jun 29, 2020

👍 on this, here is a link to the corresponding Laravel issue: laravel/laravel#5138 (comment)

Basically this token is part of the AWS credentials in some systems (including AWS Lambda), it is necessary to make it work.

@patrickcarlohickman patrickcarlohickman merged commit 07dd2f8 into shiftonelabs:master Jun 29, 2020
@patrickcarlohickman
Copy link
Contributor

Awesome. Thank you for the PR and both of you for the explanation and context.

@patrickcarlohickman
Copy link
Contributor

One more piece: PR for Laravel SQS connector - laravel/framework#24746

@patrickcarlohickman
Copy link
Contributor

patrickcarlohickman commented Jun 29, 2020

Also laravel/framework#23766, with an explanation that everything should still work fine if the token key is not found.

@mnapoli
Copy link

mnapoli commented Jun 30, 2020

Awesome!

@patrickcarlohickman
Copy link
Contributor

I've tagged a new release with the change (1.2.0). Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants