-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide print cal #759
base: main
Are you sure you want to change the base?
Hide print cal #759
Conversation
1. ical feed was giving trailing line whitespace for words, but the tests were never updated 2. on my new machine i was getting EPIPE errors on some of the test runs; reading the file first seems to fix things? ( maybe just slows things down enough for pipes to be happy? )
- .Site.Params.pedalp.enablePrintCal can be toggled int the config.toml - edit.html hides the print fields in that case - the validator doesn't write the fields into the "values" object unless "tinytitle" is in the input data, that way -- in calEvent.js updateFromJSON() the `Object.assign()` won't overwrite the existing values
One wrinkle is that we currently use the
If Examples: https://www.shift2bikes.org/calendar/event-19034
https://www.shift2bikes.org/calendar/event-19302
(For the 2nd one, that there are 4 similar rides, 1 from each district. With the auto-truncated title, they all have the same short title.) |
that's a good catch. a couple related thoughts:
|
Yeah, agreed that we've sort of muddied up the meaning of both "print" fields. We also use (See also #576) |
in the same spirit as #753, simplify the edit form by hiding the print calendar ( based on site configuration. )
Object.assign()
won't overwrite the existing values