Add error message

shield-wall · Mar 27, 2023 · 642db3a · 642db3a
1 parent 5c83fea
commit 642db3a
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 14 deletions.
diff --git a/.github/workflows/discussion-comment.yaml b/.github/workflows/discussion-comment.yaml
@@ -19,7 +19,6 @@ jobs:
                 with:
                     organization: 'shield-wall'
                     repository: 'myprofile'
-#                    discussionId: ${{inputs.php_versions}}
                     discussionId: ${{inputs.discussionId}}
                     body: ${{inputs.body}}
 
diff --git a/.github/workflows/resume.yaml b/.github/workflows/resume.yaml
@@ -8,6 +8,7 @@ on:
 
 jobs:
     discussion-comment-initial:
+        name: Initial comment
         uses: shield-wall/myprofile/.github/workflows/discussion-comment.yaml@master
         if: github.event_name == 'discussion'
         with:
@@ -22,6 +23,8 @@ jobs:
         runs-on: ubuntu-latest
         name: Generate pdf
         if: github.event_name == 'discussion' || github.event.label.name == 'template'
+        outputs:
+            yaml-lint: ${{ steps.yaml-lint-output.outputs.message }}
         steps:
             -   uses: actions/checkout@v3
             -   uses: actions/cache@v3
@@ -42,14 +45,23 @@ jobs:
                 with:
                     path: ./data/data.txt
                     contents: ${{github.event.discussion.body}}
-            -   run: |
-                    npm run node:generate:data
-                    npm run lint:check:yaml
-                if: github.event_name == 'discussion'
+
+            -   if: github.event_name == 'discussion'
+                run: npm run node:generate:data
 
             # Process from pull request.
-            -   run: npm run node:copy-data
-                if: github.event_name == 'pull_request'
+            -   if: github.event_name == 'pull_request'
+                run: npm run node:copy-data
+
+            - name: Yaml lint
+              continue-on-error: true
+              run: npm run lint:check:yaml > data/log/lint-yaml.txt
+
+            - name: Pass output lint to github output.
+              id: yaml-lint-output
+              run: |
+                cat data/log/lint-yaml.txt
+                echo "message=cat data/log/lint-yaml.txt" >> "$GITHUB_OUTPUT"
 
             -   run: npm run node:generate:json
             -   run: npm run build
@@ -68,12 +80,33 @@ jobs:
                     CLOUDFLARE_ACCOUNT_ID: ${{secrets.CLOUDFLARE_ACCOUNT_ID}}
                     CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
 
-    discussion-comment-final:
+    discussion-comment-success:
+        name: Success comment
         uses: shield-wall/myprofile/.github/workflows/discussion-comment.yaml@master
-        if: github.event_name == 'discussion'
+#        if: github.event_name == 'discussion' && needs.resume.result == 'success'
+        if: needs.resume.result == 'success'
         needs: resume
         with:
-            discussionId: ${{github.event.discussion.number}}
+#            discussionId: ${{github.event.discussion.number}}
+            discussionId: 723
             body: |
-                Your resume was processed with success :tada: :tada:
-                Resume link: https://bucket.myprofile.pro/users/${{github.actor}}/resume.pdf
+                :white_check_mark: Your resume was generated with success :tada: :tada:, you can access using the link bellow.
+                **:page_with_curl: https://bucket.myprofile.pro/users/${{github.actor}}/resume.pdf**
+
+    discussion-comment-failure:
+        name: Failure comment
+        uses: shield-wall/myprofile/.github/workflows/discussion-comment.yaml@master
+        #        if: github.event_name == 'discussion'
+        if: ${{ always() }} && needs.resume.result == 'failure'
+        needs: resume
+        with:
+            #            discussionId: ${{github.event.discussion.number}}
+            discussionId: 723
+            body: |
+                :x: :bangbang: We couldn't generate your resume :disappointed_relieved: , we found out this issue related with your **yaml syntax**.
+                Please fix the **issue** bellow and after that **edit your discussion's description** to try again :arrows_clockwise: :wink:
+                
+                :point_down: :point_down:
+                ```bash
+                    ${{needs.resume.outputs.yaml-lint}}
+                ```
diff --git a/data/.gitignore b/data/.gitignore
@@ -1,4 +1,4 @@
 json
 pdf
 data.yaml
-data.txt
+data.txt
diff --git a/data/data.yaml.dist b/data/data.yaml.dist
@@ -96,7 +96,7 @@ sectionTwo:
     #[education section]
     -   title: Education
         icon: education
-        children:
+      children:
             -   degree: Master of Arts
                 institution: Harvard
                 timePeriod: March 2012 - December 2013

diff --git a/data/log/.gitignore b/data/log/.gitignore
@@ -0,0 +1 @@
+*.txt