Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement editable #13

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Conversation

sebaiturravaldes
Copy link
Contributor

@sebaiturravaldes sebaiturravaldes commented Dec 25, 2021

With this feature, you can provide whether the code can be edited or not.

This does not affect the source code, it only gives the reader the possibility to edit the code and perform live tests.

Copy link
Owner

@shettypuneeth shettypuneeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @siturra.

src/index.js Outdated
@@ -80,6 +81,7 @@ ReactCodepen.defaultProps = {
defaultTab: 'css,result',
height: 300,
preview: true,
editable: true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this could be opt-in and defaulted to false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@shettypuneeth shettypuneeth merged commit ef5cc26 into shettypuneeth:master Jan 4, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants