Skip to content

Report a missing executable on glibc older than 2.24 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheredom merged 5 commits into from
Aug 9, 2026
Merged

Report a missing executable on glibc older than 2.24 #106

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd48c47
Fix building against glibc older than 2.29
bernardladenthin Aug 1, 2026
620ce44
Allow overriding SUBPROCESS_HAVE_CWD and document it
bernardladenthin Aug 1, 2026
71c3516
Report a missing executable on glibc older than 2.24
bernardladenthin Aug 1, 2026
d16fb72
Merge branch 'main' into fix/spawn-exec-errors-old-glibc
bernardladenthin Aug 9, 2026
a52eae7
Restore the exec-error probe lost in the merge
bernardladenthin Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions subprocess.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,20 @@ subprocess_weak int subprocess_alive(struct subprocess_s *const process);
#endif
#endif

/* Whether posix_spawn reports a failed exec back to the caller. glibc only
started doing so in 2.24; before that the child silently exits with 127. */
#if !defined(SUBPROCESS_SPAWN_REPORTS_EXEC_ERRORS)
#if defined(__GLIBC__)
#if __GLIBC_PREREQ(2, 24)
#define SUBPROCESS_SPAWN_REPORTS_EXEC_ERRORS 1
#else
#define SUBPROCESS_SPAWN_REPORTS_EXEC_ERRORS 0
#endif
#else
#define SUBPROCESS_SPAWN_REPORTS_EXEC_ERRORS 1
#endif
#endif

#if defined(_WIN32)

#include <wchar.h>
Expand Down Expand Up @@ -1350,6 +1364,17 @@ int subprocess_create_ex(const char *const commandLine[], int options,
goto cleanup;
}
} else {
#if !SUBPROCESS_SPAWN_REPORTS_EXEC_ERRORS
/* posix_spawn cannot tell us the exec failed, so check up front */
if (0 != access(commandLine[0], X_OK)) {
saved_errno = errno;
result = subprocess_error_from_errno(saved_errno);
if (subprocess_error_unknown == result) {
result = subprocess_error_spawn;
}
goto cleanup;
}
#endif
posix_error = posix_spawn(&child, commandLine[0], &actions,
SUBPROCESS_NULL,
SUBPROCESS_CONST_CAST(char *const *, commandLine),
Expand Down
Loading