-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/0.1.2 #42
release/0.1.2 #42
Conversation
WalkthroughVersion 0.1.2 of the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files skipped from review due to trivial changes (1)
Additional Context UsedLanguageTool (62)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 4 4
Lines 368 368
=======================================
Hits 313 313
Misses 55 55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
@@ -7,12 +7,16 @@ | |||
|
|||
## [Unreleased] | |||
|
|||
## [0.1.2] - 2024-04-29 | |||
|
|||
|
|||
### Changed | |||
- Implement ngram counts with a better way (#33) | |||
- Rust `compute_score` function signature changed to use references (#34) | |||
- Use rayon to run every prediction-references statistics calculation parallely (#38) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the spelling of "parallely" to "parallel".
- Use rayon to run every prediction-references statistics calculation parallely (#38)
+ Use rayon to run every prediction-references statistics calculation in parallel (#38)
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- Use rayon to run every prediction-references statistics calculation parallely (#38) | |
Use rayon to run every prediction-references statistics calculation in parallel (#38) |
Summary by CodeRabbit
bleuscore
project description for accuracy regarding its speed.compute_score
function efficiency by using references.Cargo.toml
to 0.1.2.