adds topological sort example #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 78 78
=====================================
Hits 78 78Continue to review full report at Codecov.
|
package.json
Outdated
| @@ -41,7 +41,8 @@ | |||
| "dependencies": { | |||
| "fs-extra": "^0.30.0", | |||
| "lodash": ">=3.5 <5", | |||
| "mutexify": "1.0.1" | |||
| "mutexify": "1.0.1", | |||
| "toposort": "^1.0.3" | |||
There was a problem hiding this comment.
Can you move that to devDependencies
SeeThruHead
force-pushed
the
generate-toposort-example
branch
from
67de04c
to
6f339a4
Compare
| vendor: './util.js' | ||
| }, | ||
| output: { | ||
| filename: '[name].out.js' |
There was a problem hiding this comment.
can you set output.path to path.join(__dirname, 'build') and filename to [name].js
I've got plan for the future to use those in tests, that will make it easier
| var nodeMap = {}; | ||
|
|
||
| files.forEach(function (file) { | ||
| nodeMap[file.chunk.id] = file; |
There was a problem hiding this comment.
I think this needs an isChunk guard.
| var edges = []; | ||
|
|
||
| files.forEach(function (file) { | ||
| if (file.chunk.parents) { |
There was a problem hiding this comment.
so i'm not actually all that familiar with webpack, what kind of dependency tree would give me files without chunks? I supposed the example should handle that case? or is it sufficient to handle the actual case that the example files dep tree creates (all files are chunks?)
There was a problem hiding this comment.
Oops sorry, missed that comment.
We include emitted files (for example from copy-webpack-plugin), basically it's every non-js files. I think those better be at the end (but really I don't care, up to you!)
|
i can take a look at this tmrw. what better way to spend my airport wait :D |
|
Hey @SeeThruHead :) Let me know how you are getting on with that. Do you want me to take it over (I will have more time in a couple of weeks)? |
|
hey @mastilver I made a comment above asking for some guidance with how to test an isChunk guard. ie what kind of dep tree would give me files without chunks. |
|
This is really good stuff, I'd love to see it get merged so it gets more visibility! One thing I noticed in the example is there is a It's my first time trying this plugin, so maybe that is for a different version? Wondering if this PR needs some TLC before it gets merged. |
|
it's a bit brutal, but I've done it here https://github.com/caub/webpack-manifest-plugin/blob/m2/lib/plugin.js (the logic actually mostly copied from HtmlWebpackPlugin) I think the manifest file deserves to be sorted by default, I couldn't use the generate option easily |
|
html-webpack-plugin is getting rid of toposort in flavours of |
|
I think it's possible to get rid of it only with webpack4, but not sure |
|
@SeeThruHead Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've just landed a major refactor in #222, and part of that is only supporting webpack v4.44.0+. Please let me know if you're interested in reopening this PR and we'll move forward. |
add topological sort to new examples folder
adds examples readme entry with link to specific example
gitignore example output files
prior work: #79