Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursively extract all assets from all child compilations #211

Closed
wants to merge 1 commit into from
Closed

fix: recursively extract all assets from all child compilations #211

wants to merge 1 commit into from

Conversation

wood1986
Copy link

fix #210

@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #211   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         128    132    +4     
  Branches       26     26           
=====================================
+ Hits          128    132    +4
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55ac5d...4a6cb46. Read the comment docs.

@shellscape
Copy link
Owner

@wood1986 Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've landed a major refactor in #222 that has resulted in some significant conflicts. Moving forward, we'll recommend the fix mentioned in #210 (comment)

@shellscape shellscape closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assets generated from the child compiler whose key has hash in the manifest.json
3 participants